Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splines kokkos kernels backend #480

Merged
merged 261 commits into from
Jul 17, 2024
Merged

Splines kokkos kernels backend #480

merged 261 commits into from
Jul 17, 2024

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Jun 5, 2024

No description provided.

@blegouix
wip
6238ca3
@blegouix
improve consistency
6ab4a97
@blegouix
Merge branch 'main' into clarify-spline-names
64659a7
@blegouix
wip
66ea164
@blegouix
wip
2fdb975
@blegouix
spline_builder
93ec4a0
@blegouix
changes from Emiliy's reviw
29367d7
@blegouix
format
97a042e
@blegouix
minor
84e76df
@blegouix
wip
aa7b594
@blegouix
Merge branch 'clarify-spline-names' into splines-doc
3ea940f
@blegouix
wip
ffef0b2
@blegouix
wip
2a050b0
@blegouix
bsplines
880353b
@blegouix
init
39f2d70
@blegouix
reinit
c0ef458
@blegouix
remove bsplines (not in the scope of this MR anymore)
56dbf4e
@blegouix
format
85a2a0f
@blegouix
autoreview
17bb0ba
@blegouix
wip
7e6c05b
@blegouix
Merge branch 'main' into splines-doc2
8c3bb44
@blegouix
wip
d7472c7
@blegouix
Merge branch 'main' into splines-doc2
d98abe5
@blegouix
wip
a563f6d
@blegouix
fix for allowing doxygen to keep track of integrals()
7017234
@blegouix
format
dcc5c6f
@blegouix
Revert "fix for allowing doxygen to keep track of integrals()"
8f7f760 
This reverts commit 7017234.
@blegouix
autoreview
9d675c9
@blegouix
Merge branch 'main' into splines-doc2
51ffa31
@blegouix
Merge branch 'main' into splines-doc
2d0737c
@blegouix blegouix marked this pull request as ready for review July 2, 2024 16:39
Base automatically changed from lapack-backend to main July 3, 2024 06:30
tpadioleau
tpadioleau requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems globally fine to me!

vendor/kokkos-kernels Outdated Show resolved Hide resolved
include/ddc/kernels/splines/splines_linear_problem_pds_tridiag.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/splines_linear_problem_pds_band.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/splines_linear_problem_band.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/splines_linear_problem_band.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/splines_linear_problem_pds_tridiag.hpp Outdated Show resolved Hide resolved
tpadioleau
tpadioleau reviewed Jul 5, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@yasahi-hpc yasahi-hpc mentioned this pull request Jul 8, 2024
Draft
tpadioleau
tpadioleau reviewed Jul 9, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@blegouix @tpadioleau
Update CMakeLists.txt
7205da4 
Co-authored-by: Thomas Padioleau <[email protected]>
@tpadioleau
Copy link
Member

Approved, stalled because of coordination with the Gysela team.

@blegouix blegouix mentioned this pull request Jul 10, 2024
Merged
@blegouix
Copy link
Collaborator Author

@tpadioleau need the real approval, maybe take a last look at beb1ee9 and the splines order 1 issue

tpadioleau
tpadioleau approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. Maybe wait for Gysela to have updated to Ginkgo 1.8.0 before merging ?

@yasahi-hpc
Copy link
Member

Let me confirm that GYSELA has a control to choose ginkgo or KK as a spline solver.
If this is the case, I think this PR is ready

@blegouix
Copy link
Collaborator Author

blegouix commented Jul 16, 2024 •
edited
Loading

Ok for me. Maybe wait for Gysela to have updated to Ginkgo 1.8.0 before merging ?

Ok in case Ginkgo 1.8 breaks something

Let me confirm that GYSELA has a control to choose ginkgo or KK as a spline solver. If this is the case, I think this PR is ready

Yes, LAPACK or GINKGO is specified in template argument of SplineBuilders

@blegouix blegouix merged commit a3ecc1b into main Jul 17, 2024
49 checks passed
@blegouix blegouix deleted the kokkos-kernels-backend branch July 17, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc left review comments

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

@yasahi-hpc yasahi-hpc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blegouix @tpadioleau @yasahi-hpc